-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: merge runtime-ffi repository #352
Conversation
948b76b
to
44019ef
Compare
Will you fix the CI in this PR? Or at a later stage? You could make the CMake such that if no path is specified for the binaries, than you build them? That way you can always use this repository and we don't have to update the repositories with the binaries! See SixtyFPS for a way how. |
Yeah, I got the notification that CI failed but didn't have time to look at it yet. Will fix! |
586ce50
to
75d701d
Compare
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 82.54% 82.54%
=======================================
Files 264 264
Lines 15294 15294
=======================================
Hits 12624 12624
Misses 2670 2670
Continue to review full report at Codecov.
|
bc37a56
to
c0bf84b
Compare
c0bf84b
to
83a60b9
Compare
CI is fixed. Ready to review, @baszalmstra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase on main
? There are still a few LLVM12 changes in here.
5ea9806
to
c0a904a
Compare
Merges https://github.com/mun-lang/runtime-ffi into https://github.com/mun-lang/mun, allowing us to archive the former and have a single CI pipleine