feat: add missing validations in the database #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Couldn't really find any other strict restrictions for username&password for all of the databases; these datafields can be anything that is utf-8 encoded really, only restricted in maximum length; |
goncalo-rodrigues
requested changes
Aug 2, 2022
Resolves multycloud#387 - add supported versions of mariadb on both azure and aws; - check username & password; - check if dbsize is not set to unknown; - some minor validation structure refactor (use Validator interface);
szymonnogiec
force-pushed
the
feat-db-missing-validations
branch
from
ff6d733 to
9993e35
Compare
goncalo-rodrigues
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #387