Change AddProof #6712
Merged
Change AddProof #6712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
changed the title
| if err != nil { | ||
| log.Error("failed to add proof", "error", err, "intercepted header hash", interceptedHdr.Hash(), "header type", reflect.TypeOf(interceptedHdr.HeaderHandler())) | ||
| } | ||
| _ = hip.proofs.AddProof(interceptedHdr.HeaderHandler().GetPreviousProof()) |
There was a problem hiding this comment.
maybe a log.Trace here?
sstanculeanu
previously approved these changes
Jan 16, 2025
Base automatically changed from
equivalent-proofs-feat-stabilization
to
feat/equivalent-messages
January 20, 2025 11:41
Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>
AdoAdoAdo
reviewed
Jan 20, 2025
| log.Warn("ProofsPool.AddProof", "currHdrHash", currHdrHash, "node", tpn.OwnAccount.Address, "err", err.Error()) | ||
| wasAdded := tpn.ProofsPool.AddProof(previousProof) | ||
| if !wasAdded { | ||
| log.Warn("ProofsPool.AddProof not added", "currHdrHash", currHdrHash, "node", tpn.OwnAccount.Address) | ||
| } | ||
| return err |
There was a problem hiding this comment.
should not return an error here
| if p.AddProofCalled != nil { | ||
| return p.AddProofCalled(headerProof) | ||
| } | ||
|
|
||
| return nil | ||
| return false |
AdoAdoAdo
approved these changes
Jan 20, 2025
sstanculeanu
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?