Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spamming warnings from apiTransactionProcessor #6604

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • SilentEncode prints a Warn log due to empty guardian address. The proper fix should be inside SilentEncode method, a simple check if len of pkBytes is 0 to return an empty string. Will be fixed in a next release.

Proposed changes

  • added a length check for guardian address to avoid SilentEncode on empty string

Testing procedure

  • standard system test, call either /transaction/pool/by-sender with some txs in pool, either /transaction/pool and check for warn like: bech32PubkeyConverter.SilentEncode hex buff = error = wrong size when encoding address, expected length 32, received 0

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu merged commit 20dde29 into selection-by-ppu Nov 14, 2024
2 checks passed
@sstanculeanu sstanculeanu deleted the fix_spam_logs branch November 14, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants