Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vm common version and add integration tests #6488

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • If the metaData of a dynamic token is updated by an address which does not have the actual token in it's balance, the update works as expected, but the nonce field is not set, so it will be 0.

Proposed changes

  • In the case described above, set the nonce field with the actual nonce of the token
  • Add more integration tests

Testing procedure

  • Normal test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sasurobert
sasurobert previously approved these changes Sep 23, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 965682c1749bdfdbe35e06b82f16e5688b6197e6
  • Current Branch: zero-nonce-metadata-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 23092024-132259
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@ssd04 ssd04 self-requested a review September 23, 2024 13:25
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 61a1de9ae3058ff432d9ebb6d366d7c4a5e77e0f
  • Current Branch: zero-nonce-metadata-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 23092024-132940
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 7c480fa3240343b9377cc5ebba29ac9442eb212b
  • Current Branch: zero-nonce-metadata-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 23092024-135858
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 9c1e2318eb4cace6998f1c167dd6075cb38bc4cc
  • Current Branch: zero-nonce-metadata-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 24092024-105729
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.7.13-patch2-41962f78a1 -> zero-nonce-metadata-fix-7c480fa324

--- Specific errors ---

block hash does not match 649
wrong nonce in block 477
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 1
Nr. of all WARNS: 497
Nr. of new ERRORS: 1
Nr. of new WARNS: 8
Nr. of PANICS: 0

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

@BeniaminDrasovean BeniaminDrasovean merged commit 702a810 into rc/v1.7.next1 Sep 24, 2024
8 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the zero-nonce-metadata-fix branch September 24, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants