Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix gh action #6387

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix gh action #6387

merged 2 commits into from
Aug 16, 2024

Conversation

btc-fan
Copy link
Contributor

@btc-fan btc-fan commented Aug 13, 2024 •
edited
Loading

Reasoning behind the pull request

  • Addressed issues where the workflow was incorrectly using the target branch instead of the PR source branch.
  • Fixed branch resolution logic to correctly handle cases where branches are missing or comments don't specify branches.
  • Resolved dependency conflicts in mx-chain-testing-suite related to protobuf versions.

Proposed changes

  • Updated GitHub Action to correctly fetch and use the latest commit from the PR source branch.
  • Implemented logic to skip branch overrides when the last comment does not contain "Run Tests:".
  • Adjusted requirements.txt in mx-chain-testing-suite to resolve protobuf version conflicts.

Testing procedure

  • Verified that the workflow correctly checks out the source branch and uses the latest commit hash.
  • Tested the branch override logic by adding and omitting "Run Tests:" in PR comments.
  • Confirmed that the dependency update does not introduce new issues and that all tests pass.

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@btc-fan btc-fan self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan btc-fan force-pushed the integrate-sys-tests-ci2 branch from 5d1a88a to 4cad0b1 Compare August 13, 2024 13:02
@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

bla bla bla

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

bla bla bla

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan btc-fan force-pushed the integrate-sys-tests-ci2 branch from 4cad0b1 to 536033a Compare August 13, 2024 13:18
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

bla bla

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan btc-fan force-pushed the integrate-sys-tests-ci2 branch from 536033a to 226fe65 Compare August 13, 2024 13:23
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

dsfgdsfyg dsfg dsfg

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

1 similar comment
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan btc-fan force-pushed the integrate-sys-tests-ci2 branch from 226fe65 to e8f7d9f Compare August 13, 2024 13:49
@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

Run Tests:
mx-chain-simulator-go: main
mx-chain-testing-suite: main

@btc-fan
Copy link
Contributor Author

btc-fan commented Aug 13, 2024

zsdgvfdsfgsd

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e8f7d9f8fa5c71eef00944d9854f29f230dae1ea
  • Current Branch: integrate-sys-tests-ci2
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 13082024-141525
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

andreibancioiu
andreibancioiu approved these changes Aug 14, 2024
View reviewed changes
.github/workflows/build_and_run_chain_simulator_and_execute_system_test.yml
Comment on lines +79 to +80
const simulatorBranchMatch = body.match(/mx-chain-simulator-go:\s*(\S+)/);
const testingSuiteBranchMatch = body.match(/mx-chain-testing-suite:\s*(\S+)/);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

GH workflow inputs (pretty visual forms) would have permitted us to not write regex.

GH workflow inputs support default values (of course, without additional conditions as above, but might be sufficient).

@github-actions GitHub Actions
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 29f6aee44c0ebcf24f45ad8ff0942c1c917469d0
  • Current Branch: integrate-sys-tests-ci2
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 14082024-111107
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@btc-fan btc-fan merged commit ae7b021 into rc/v1.7.next1 Aug 16, 2024
10 checks passed
@btc-fan btc-fan deleted the integrate-sys-tests-ci2 branch August 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miiu96 miiu96 miiu96 approved these changes

@sstanculeanu sstanculeanu sstanculeanu approved these changes

@andreibancioiu andreibancioiu andreibancioiu approved these changes

@AdoAdoAdo AdoAdoAdo Awaiting requested review from AdoAdoAdo

@cristure cristure Awaiting requested review from cristure

@BeniaminDrasovean BeniaminDrasovean Awaiting requested review from BeniaminDrasovean

@axenteoctavian axenteoctavian Awaiting requested review from axenteoctavian

@raduchis raduchis Awaiting requested review from raduchis

@iulianpascalau iulianpascalau Awaiting requested review from iulianpascalau

Assignees

@btc-fan btc-fan

Labels
github-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btc-fan @andreibancioiu @sstanculeanu @miiu96