Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some tests and add more checks #6383

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • In order for the versioning of esdt metadata to work, a proper blockchain hook impl needed to be given to the builtInFuncFactory
  • Refactor some integration tests to cover more scenarios

Proposed changes

  • Set the real blockchain hook implementation in the built in func factory

Testing procedure

  • normal testing scenario
  • esdt improvements scenarios

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sasurobert
sasurobert previously approved these changes Aug 12, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 8eaa7e30ca77c032794eb84dc3c47597969b7bdf
  • Current Branch: fix-esdt-metaData-in-system-account
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: ``
  • mx-chain-testing-suite Target Branch: ``

🚀 Environment Variables:

  • TIMESTAMP: 14082024-064759
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-7cab1a501e -> fix-esdt-metaData-in-syste-a9e2b8f759

--- Specific errors ---

block hash does not match 2092
wrong nonce in block 839
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 1324
Nr. of new ERRORS: 0
Nr. of new WARNS: 15
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 110838bfc2ae8625ecfef3e34813d98261fa16d3
  • Current Branch: fix-esdt-metaData-in-system-account
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 16082024-093648
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e88633b1810415c60654967d84704c9293ecfca1
  • Current Branch: fix-esdt-metaData-in-system-account
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 16082024-110818
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@ssd04 ssd04 merged commit bcfafbc into rc/v1.7.next1 Aug 16, 2024
10 checks passed
@ssd04 ssd04 deleted the fix-esdt-metaData-in-system-account branch August 16, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants