New endpoint /transaction/scrs-by-tx-hash/:txHash #6373
Conversation
…to new-endpoint-scrs-by-tx-hash
| return nil, fmt.Errorf("%s: %w", ErrTransactionNotFound.Error(), err) | ||
| } | ||
|
|
||
| resultsHashes, err := atp.historyRepository.GetResultsHashesByTxHash(decodedTxHash, miniblockMetadata.Epoch) |
There was a problem hiding this comment.
please check: I think we also need to query the same miniblock on the next epoch. I think the miniblock is now stored only once based on the source epoch. There is a chance that the destination epoch is the next source epoch.
There was a problem hiding this comment.
The results hashes contains information for multiple epochs.
This case in covered.
| @@ -64,6 +64,8 @@ var ErrTxGenerationFailed = errors.New("transaction generation failed") | |||
| // ErrValidationEmptyTxHash signals that an empty tx hash was provided | |||
| var ErrValidationEmptyTxHash = errors.New("TxHash is empty") | |||
|
|
|||
| var ErrValidationEmptySCRHash = errors.New("SCRHash is empty") | |||
| return nil, err | ||
| } | ||
|
|
||
| scrsAPI := make([]*transaction.ApiSmartContractResult, 0) |
There was a problem hiding this comment.
| scrsAPI := make([]*transaction.ApiSmartContractResult, 0) | |
| scrsAPI := make([]*transaction.ApiSmartContractResult, 0, len(resultsHashes.ScResultsHashesAndEpoch)) |
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
There was a problem hiding this comment.
Normal allin test: rc -> new-endpoint-scrs-by-tx-ha-3cbcc0c7fc
--- Specific errors ---
block hash does not match 651
wrong nonce in block 304
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 1
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 263
Nr. of new ERRORS: 0
Nr. of new WARNS: 10
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
Reasoning behind the pull request
Proposed changes
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?