Deep VM Queries (for older epochs, as well) #5801
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.next1 #5801 +/- ##
=================================================
- Coverage 80.21% 80.17% -0.04%
=================================================
Files 708 708
Lines 94124 94129 +5
=================================================
- Hits 75497 75466 -31
- Misses 13282 13316 +34
- Partials 5345 5347 +2 ☔ View full report in Codecov by Sentry. |
andreibancioiu
changed the title
Add integration test for deep queries
|
☑️ Tested using integration test: #5935 ☑️ Tested on Testnet:
Contract used to test on Testnet: |
|
|
||
| require.Equal(t, snapshotsOfGetState[1], historyOfGetState[1]) | ||
| require.Equal(t, snapshotsOfGetNow[1].blockNonce, historyOfGetNow[1].blockNonce) | ||
| // This does not seem right! |
There was a problem hiding this comment.
Though, I think the issue is with the test node, not with the actual implementation of deep queries. Actual implementation tested on system-test / Testnet ☑️
There was a problem hiding this comment.
Removed that (redundant & ambiguous) assertion.
factory/api/apiResolverFactory.go
Outdated
| @@ -356,10 +356,20 @@ func createScQueryElement( | |||
| return nil, errDecode | |||
| } | |||
|
|
|||
| apiBlockchain, err := blockchain.NewBlockChain(disabled.NewAppStatusHandler()) | |||
There was a problem hiding this comment.
Here we should handle metachain, as well.
There was a problem hiding this comment.
Fixed in #5958.
Deep queries on metachain
| @@ -47,3 +48,7 @@ func CreateScQueryElement(args SCQueryElementArgs) (process.SCQueryService, erro | |||
| guardedAccountHandler: args.GuardedAccountHandler, | |||
| }) | |||
| } | |||
|
|
|||
| func CreateBlockchainForScQuery(selfShardID uint32) (data.ChainHandler, error) { | |||
There was a problem hiding this comment.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> sandbox-queries-dc797c7a20
--- Specific errors ---
block hash does not match 1448
wrong nonce in block 781
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 4
Nr. of all WARNS: 573
Nr. of new ERRORS: 0
Nr. of new WARNS: 4
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
upcloud-fra-validator-19 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
upcloud-fra-validator-29 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
/------/
iulianpascalau
dismissed stale reviews from gabi-vuls and sstanculeanu
via
5a3ec4d
There was a problem hiding this comment.
Normal allin test: v1.6.15-dev-config-eb2e06c06d -> sandbox-queries-dc797c7a20
--- Specific errors ---
block hash does not match 1448
wrong nonce in block 781
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 4
Nr. of all WARNS: 573
Nr. of new ERRORS: 0
Nr. of new WARNS: 4
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
upcloud-fra-validator-19 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
upcloud-fra-validator-29 :
Warn: shardProcessor.createMiniBlocks error = shard is stuck shard = 2
/------/
Reasoning behind the pull request
Enabled VM queries for older (all) epochs. Previously, VM queries were possible at blocks within epochs covered by the active persisters (e.g. last 3 epochs).
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?