-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace SendTxRequest with FrontendTransaction #5649
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.0 #5649 +/- ##
=============================================
- Coverage 80.34% 80.26% -0.08%
=============================================
Files 708 706 -2
Lines 94096 93908 -188
=============================================
- Hits 75601 75378 -223
- Misses 13187 13223 +36
+ Partials 5308 5307 -1
☔ View full report in Codecov by Sentry. |
|
||
// SendTxRequest represents the structure that maps and validates user input for publishing a new transaction | ||
type SendTxRequest struct { | ||
Sender string `form:"sender" json:"sender"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
the transaction.FrontendTransaction's fields matches this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.5.13-dev-config-8c685c8e00 -> remove_sendtxrequest-16e5d20bd2
--- Specific errors ---
block hash does not match 1915
wrong nonce in block 647
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 1
Nr. of all WARNS: 124
Nr. of new ERRORS: 1
Nr. of new WARNS: 1
Nr. of PANICS: 0
/------/
--- ERRORS ---
mx-testnet-gcp-mil-obs-0 :
Error: context deadline exceeded while closing the http server in gin/webServer 1
/------/
--- WARNINGS ---
mx-testnet-gcp-mil-node-29 :
Warn: trie recreate error: error = getNodeFromDB error: key not found for key root = 1
/------/
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?