-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes in import-db for rc/v1.6.0 #5522
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5522 +/- ##
=============================================
- Coverage 80.07% 80.03% -0.04%
=============================================
Files 708 708
Lines 93692 93696 +4
=============================================
- Hits 75021 74994 -27
- Misses 13321 13351 +30
- Partials 5350 5351 +1
☔ View full report in Codecov by Sentry. |
… fixes-import-db-2023.08.24
5158f72
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal allin test: v1.5.13-dev-config-8c685c8e00 -> fixes-import-db-2023.08.24-e194f576f4
--- Specific errors ---
block hash does not match 7464
wrong nonce in block 2451
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 1
Nr. of all WARNS: 169
Nr. of new ERRORS: 0
Nr. of new WARNS: 1
Nr. of PANICS: 0
Reasoning behind the pull request
wrong assertion type when creating peer authentication requester
Proposed changes
trieStorageManager.ExitPruningBufferingMode()
in theearlySnapshotCompletion
function. Skip the waiting for new epoch in case the node is in import-db mode in functionwaitForStorageEpochChange
.Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?