Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vmquery with block coordinates #5512

Merged
merged 20 commits into from
Aug 25, 2023

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • no option to query the vm for a specific block

Proposed changes

  • added support for vm query with block nonce and block hash

Testing procedure

Note should be tested with proxy branch vm_query_with_coordinates and checked both on node and proxy

  • standard system test + check /vm-values group works as before(/hex, /string, /int, /query)
  • also check the new options /vm-values/query?blockNonce=... and /vm-values/query?blockHash=...
  • a good test example would be:
    • issue some new token
    • check /vm-values/query?blockNonce=... for the block nonce when the token was issued -> should work
    • check the same route for an older nonce -> token should not exists
    • change some attribute of the new token
    • check /vm-values/query?blockNonce=... with the block nonce that the attribute was changed -> should reflect the changes

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 75.30% and project coverage change: -0.03% ⚠️

Comparison is base (1cf3385) 80.09% compared to head (9986b2e) 80.07%.
Report is 1 commits behind head on rc/v1.6.0.

❗ Current head 9986b2e differs from pull request most recent head e4add87. Consider uploading reports for the commit e4add87 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           rc/v1.6.0    #5512      +/-   ##
=============================================
- Coverage      80.09%   80.07%   -0.03%     
=============================================
  Files            708      708              
  Lines          93428    93692     +264     
=============================================
+ Hits           74829    75021     +192     
- Misses         13284    13321      +37     
- Partials        5315     5350      +35     
Files Changed Coverage Δ
process/smartContract/hooks/blockChainHook.go 92.24% <0.00%> (-0.40%) ⬇️
facade/nodeFacade.go 93.85% <63.63%> (-1.07%) ⬇️
factory/api/apiResolverFactory.go 83.08% <71.60%> (-10.76%) ⬇️
process/smartContract/scQueryService.go 79.01% <72.41%> (-8.49%) ⬇️
factory/processing/processComponents.go 80.98% <80.95%> (+0.01%) ⬆️
genesis/process/shardGenesisBlockCreator.go 76.87% <81.81%> (+0.05%) ⬆️
genesis/process/metaGenesisBlockCreator.go 73.55% <83.33%> (+0.14%) ⬆️
api/groups/vmValuesGroup.go 100.00% <100.00%> (ø)
facade/initial/initialNodeFacade.go 93.82% <100.00%> (ø)
genesis/process/genesisBlockCreator.go 65.95% <100.00%> (+0.18%) ⬆️
... and 10 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…y_with_coord_2023.08.22

Merge rc160 into feat vmquery with coord 2023.08.22
gabi-vuls
gabi-vuls previously approved these changes Aug 25, 2023
sstanculeanu and others added 4 commits August 25, 2023 10:17
…into merge_rc160_into_feat_vmquery_with_coord_2023.08.25
…y_with_coord_2023.08.25

Merge rc160 into feat vmquery with coord 2023.08.25
add missing param initialization causing
@iulianpascalau iulianpascalau self-requested a review August 25, 2023 09:12
@AdoAdoAdo AdoAdoAdo merged commit fce29e5 into rc/v1.6.0 Aug 25, 2023
@AdoAdoAdo AdoAdoAdo deleted the feat/vmquery_with_block_coordinates branch August 25, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants