-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/vmquery with block coordinates #5512
Conversation
Block coordinates on vm query
…into feat/vmquery_with_block_coordinates
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5512 +/- ##
=============================================
- Coverage 80.09% 80.07% -0.03%
=============================================
Files 708 708
Lines 93428 93692 +264
=============================================
+ Hits 74829 75021 +192
- Misses 13284 13321 +37
- Partials 5315 5350 +35
☔ View full report in Codecov by Sentry. |
…y_with_coord_2023.08.22 Merge rc160 into feat vmquery with coord 2023.08.22
…into merge_rc160_into_feat_vmquery_with_coord_2023.08.25
…y_with_coord_2023.08.25 Merge rc160 into feat vmquery with coord 2023.08.25
add missing param initialization causing
Reasoning behind the pull request
Proposed changes
Testing procedure
Note should be tested with proxy branch
vm_query_with_coordinates
and checked both on node and proxy/vm-values
group works as before(/hex, /string, /int, /query)/vm-values/query?blockNonce=...
and/vm-values/query?blockHash=...
/vm-values/query?blockNonce=...
for the block nonce when the token was issued -> should work/vm-values/query?blockNonce=...
with the block nonce that the attribute was changed -> should reflect the changesPre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?