Source messenger on ProcessReceivedMessage #5365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
requesters_resolvers_full_archive_network
to
feat/multiple_p2p_messengers
June 21, 2023 11:36
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/multiple_p2p_messengers #5365 +/- ##
================================================================
- Coverage 80.33% 80.32% -0.01%
================================================================
Files 695 695
Lines 90497 90486 -11
================================================================
- Hits 72698 72685 -13
- Misses 12630 12631 +1
- Partials 5169 5170 +1
☔ View full report in Codecov by Sentry. |
sstanculeanu
changed the title
| @@ -13,8 +13,8 @@ import ( | |||
| type FactoryArgs struct { | |||
| RequesterConfig config.RequesterConfig | |||
| ShardCoordinator sharding.Coordinator | |||
| MainMessenger dataRetriever.TopicMessageHandler | |||
| FullArchiveMessenger dataRetriever.TopicMessageHandler | |||
| MainMessenger p2p.Messenger | |||
There was a problem hiding this comment.
We should evaluate that we can get rid of providing the messenger on the resolvers as the messenger is now provided on each data request. (next PR)
p2p/constants.go
Outdated
| type MessageHandlerType = p2p.MessageHandlerType | ||
|
|
||
| // RegularMessageHandler defines a message handler for the main network | ||
| const RegularMessageHandler = p2p.RegularMessageHandler |
…andler type concept
iulianpascalau
previously approved these changes
Jun 23, 2023
| } | ||
| err = fullArchiveMessenger.SetPeerShardResolver(peerShardMapperFullArch) | ||
| if err != nil { | ||
| log.Error("error setting NewPeerShardMapper in p2p messenger for full archive network", "error", err) |
There was a problem hiding this comment.
log.Error("error setting a peer shard mapper in p2p messenger for full archive network", "error", err)
iulianpascalau
approved these changes
Jun 26, 2023
bogdan-rosianu
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?