Feat/multikey metrics #5362
Merged
Feat/multikey metrics #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Managed peers monitor
New API endpoints for managed keys
sstanculeanu
added
type:feature
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5362 +/- ##
=============================================
+ Coverage 79.97% 80.00% +0.03%
=============================================
Files 703 704 +1
Lines 92672 92828 +156
=============================================
+ Hits 74113 74270 +157
- Misses 13241 13242 +1
+ Partials 5318 5316 -2
☔ View full report in Codecov by Sentry. |
Update metrics for managed keys
…into merge_rc160_into_feat_multikey_metrics_2023.06.22
…ey_metrics_2023.06.22 Merge rc160 into feat multikey metrics 2023.06.22
iulianpascalau
approved these changes
Jun 22, 2023
iulianpascalau
requested changes
Jun 22, 2023
| @@ -1043,6 +1043,7 @@ func (sp *shardProcessor) CommitBlock( | |||
| highestFinalBlockNonce, | |||
| lastCrossNotarizedHeader, | |||
| header, | |||
| sp.managedPeersHolder, | |||
There was a problem hiding this comment.
you forgot to set the managedPeersHolder value and is always nil. Failed at system testnet.
Please add this line on L121:
managedPeersHolder: arguments.ManagedPeersHoldersomething similar to what we have on metablock.go L137
There was a problem hiding this comment.
🤦♂️ fixed in #5371
…alization Fix managed peers holder initialization
iulianpascalau
previously approved these changes
Jun 22, 2023
All managed keys endpoint
…into merge_rc160_into_feat_multikey_metrics_2023.06.26
…ey_metrics_2023.06.26 Merge rc160 into feat multikey metrics 2023.06.26
iulianpascalau
previously approved these changes
Jun 28, 2023
…into merge_rc160_into_feat_multikey_metrics_2023.07.07 # Conflicts: # errors/errors.go
…ey_metrics_2023.07.07 Merge rc160 into feat multikey metrics 2023.07.07
…into merge_rc160_into_feat_multikey_metrics_2023.07.10
…ey_metrics_2023.07.10 Merge rc160 into feat multikey metrics 2023.07.10
…into merge_rc160_into_feat_multikey_metrics_2023.05.11
gabi-vuls
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
multikey_metrics
================================================================================
- Known Warnings 12
- New Warnings 4
- Known Errors 1
- New Errors 1
- Panics 0
================================================================================ - block hash does not match 9345
- wrong nonce in block 4028
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
…ey_metrics_2023.05.11 Merge rc160 into feat multikey metrics 2023.05.11
ssd04
approved these changes
Jul 11, 2023
iulianpascalau
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
node/managed-keys/countfor the total number of managed keysnode/managed-keysfor all keys managed by the nodenode/managed-keys/eligiblefor the eligible keys managed, in the current epoch, from the same shard as the nodenode/managed-keys/waitingfor the waiting keys managed, in a the current epoch, from the same shard as the nodeTesting procedure
erd_count_consensus,erd_consensus_state,erd_count_consensus_accepted_blocks,erd_count_leader,erd_consensus_round_state,Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?