Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feat/balance data tries 29may #5287

Merged

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • Merge PR

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

bogdan-rosianu and others added 30 commits April 19, 2023 13:20
…h-checks

# Conflicts:
#	common/enablers/enableEpochsHandler.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	sharding/mock/enableEpochsHandlerMock.go
#	testscommon/enableEpochsHandlerStub.go
…into integrate_communication-go_with_p2p

# Conflicts:
#	go.mod
#	go.sum
…ith_p2p

Integrate communication go with p2p
bogdan-rosianu and others added 17 commits May 25, 2023 12:09
…alues-length-checks

Mx 13962 consistent tokens values length checks
…mi-int-test

added semi-integration test for relayed v2 multi nft transfers
…into dataretriever_tests

# Conflicts:
#	testscommon/storageManager/storageManagerStub.go
…nce-data-tries-29may

# Conflicts:
#	common/enablers/enableEpochsHandler.go
#	common/enablers/epochFlags.go
#	common/interface.go
#	go.mod
#	go.sum
#	sharding/mock/enableEpochsHandlerMock.go
#	testscommon/enableEpochsHandlerMock/enableEpochsHandlerStub.go
@BeniaminDrasovean BeniaminDrasovean added the ignore-for-release-notes Do not include item in release notes label May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.37 🎉

Comparison is base (8e87d66) 79.40% compared to head (10857b8) 79.78%.

❗ Current head 10857b8 differs from pull request most recent head 19dd063. Consider uploading reports for the commit 19dd063 to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/balance-data-tries    #5287      +/-   ##
===========================================================
+ Coverage                    79.40%   79.78%   +0.37%     
===========================================================
  Files                          693      693              
  Lines                        89843    89847       +4     
===========================================================
+ Hits                         71342    71684     +342     
+ Misses                       13257    12984     -273     
+ Partials                      5244     5179      -65     
Impacted Files Coverage Δ
...ataRetriever/dataPool/headersCache/headersCache.go 90.15% <ø> (+10.60%) ⬆️
common/enablers/enableEpochsHandler.go 75.88% <100.00%> (+0.17%) ⬆️
common/enablers/epochFlags.go 92.49% <100.00%> (+0.07%) ⬆️
outport/process/transactionsfee/dataHolders.go 92.85% <100.00%> (ø)
...port/process/transactionsfee/transactionChecker.go 90.00% <100.00%> (ø)
...rocess/transactionsfee/transactionsFeeProcessor.go 88.34% <100.00%> (ø)

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeniaminDrasovean BeniaminDrasovean merged commit 876f173 into feat/balance-data-tries May 29, 2023
@BeniaminDrasovean BeniaminDrasovean deleted the update-feat/balance-data-tries-29may branch May 29, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants