Coverage for: factory/data, factory/core, factory/crypto #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.6.0 #5145 +/- ##
=============================================
+ Coverage 70.90% 77.75% +6.84%
=============================================
Files 675 680 +5
Lines 87793 88348 +555
=============================================
+ Hits 62251 68694 +6443
+ Misses 20864 14313 -6551
- Partials 4678 5341 +663
... and 32 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sstanculeanu
changed the title
sstanculeanu
changed the title
ssd04
reviewed
Apr 7, 2023
factory/core/coreComponents_test.go
Outdated
Comment on lines
251
to
256
| func TestCoreComponentsFactory_CreateCoreComponentsInvalidGasScheduleShouldErr(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| args := componentsMock.GetCoreArgs() | ||
| args.EpochConfig = config.EpochConfig{} | ||
| ccf, _ := coreComp.NewCoreComponentsFactory(args) |
There was a problem hiding this comment.
change test name? invalidEpochConfig?
gabi-vuls
previously approved these changes
Apr 18, 2023
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
more_factory_tests
================================================================================
- Known Warnings 9
- New Warnings 1
- Known Errors 0
- New Errors 1
- Panics 0
================================================================================ - block hash does not match 2444
- wrong nonce in block 1010
- miniblocks does not match 0
- num miniblocks does not match 0
- miniblock hash does not match 0
- block bodies does not match 0
- receipts hash missmatch 0
================================================================================ - No jailed nodes on the testnet
================================================================================
ssd04
previously approved these changes
Apr 24, 2023
sstanculeanu
dismissed stale reviews from gabi-vuls and ssd04
The base branch was changed.
sstanculeanu
changed the title
…into more_factory_tests # Conflicts: # factory/crypto/cryptoComponents.go # factory/crypto/cryptoComponentsHandler_test.go # factory/data/dataComponents.go # factory/data/dataComponents_test.go # factory/mock/cryptoComponentsMock.go # integrationTests/mock/cryptoComponentsStub.go # integrationTests/testProcessorNode.go # node/mock/factory/cryptoComponentsStub.go # node/nodeTesting_test.go
| require.NoError(t, err) | ||
| require.Nil(t, managedCoreComponents.CheckSubcomponents()) | ||
| } | ||
| func TestManagedCoreComponents_Close(t *testing.T) { |
There was a problem hiding this comment.
add empty line on L138
| @@ -357,11 +356,6 @@ func (ccf *cryptoComponentsFactory) readCryptoParams(keygen crypto.KeyGenerator) | |||
| return nil, err | |||
| } | |||
|
|
|||
| cp.privateKeyBytes, err = cp.privateKey.ToByteArray() | |||
ssd04
previously approved these changes
Apr 25, 2023
…into more_factory_tests # Conflicts: # factory/bootstrap/bootstrapComponentsHandler_test.go # factory/bootstrap/bootstrapComponents_test.go
gabi-vuls
approved these changes
Apr 25, 2023
ssd04
approved these changes
Apr 25, 2023
iulianpascalau
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?