Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mx-chain-p2p-go #5037

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Update mx-chain-p2p-go #5037

merged 3 commits into from
Mar 1, 2023

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • update mx-chain-p2p-go to latest with p2pKeyConverter

Proposed changes

  • updated depedency

Testing procedure

  • only keygenerator binary was modified

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Feb 28, 2023
@sstanculeanu sstanculeanu self-assigned this Feb 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (rc/v1.6.0@8ba888b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 76cdef0 differs from pull request most recent head 61be05c. Consider uploading reports for the commit 61be05c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             rc/v1.6.0    #5037   +/-   ##
============================================
  Coverage             ?   70.66%           
============================================
  Files                ?      666           
  Lines                ?    86555           
  Branches             ?        0           
============================================
  Hits                 ?    61160           
  Misses               ?    20798           
  Partials             ?     4597           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: keygenerator produce valid p2p key. Seednode and node still build & work.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed

@@ Log scanner @@

integrate_latest_p2p

================================================================================

  • Known Warnings 7
  • New Warnings 1
  • Known Errors 0
  • New Errors 1
  • Panics 0
    ================================================================================
  • block hash does not match 3349
  • miniblocks does not match 0
  • miniblock hash does not match 0
  • receipts hash missmatch 0
  • wrong nonce in block 1186
    ================================================================================
  • No jailed nodes on the thestnet
    ================================================================================

@sstanculeanu sstanculeanu merged commit 765ef59 into rc/v1.6.0 Mar 1, 2023
@sstanculeanu sstanculeanu deleted the integrate_latest_p2p branch March 1, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants