-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GetNumNodes
trie functionality
#5024
Remove GetNumNodes
trie functionality
#5024
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## feat/polaris-fixes #5024 +/- ##
=====================================================
Coverage ? 70.78%
=====================================================
Files ? 649
Lines ? 85374
Branches ? 0
=====================================================
Hits ? 60436
Misses ? 20397
Partials ? 4541 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System test passed .
@@ Log scanner @@
remove-numNodes-trie-functionality
================================================================================
- Known Warnings 6
- New Warnings 1
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================ - block hash does not match 1865
- miniblocks does not match 0
- miniblock hash does not match 0
- receipts hash missmatch 0
- wrong nonce in block 782
================================================================================ - No jailed nodes on the thestnet
================================================================================
Reasoning behind the pull request
The GetNumNodes functionality had some edge cases. This functionality was solely used in tests so it can be safely removed.
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?