Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetNumNodes trie functionality #5024

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Feb 23, 2023

Reasoning behind the pull request

The GetNumNodes functionality had some edge cases. This functionality was solely used in tests so it can be safely removed.

Proposed changes

  • removed GetNumNodes trie unused functionality

Testing procedure

  • standard system-test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feat/polaris-fixes@c69e883). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 5c3d6a2 differs from pull request most recent head 1f8be7b. Consider uploading reports for the commit 1f8be7b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                  Coverage Diff                  @@
##             feat/polaris-fixes    #5024   +/-   ##
=====================================================
  Coverage                      ?   70.78%           
=====================================================
  Files                         ?      649           
  Lines                         ?    85374           
  Branches                      ?        0           
=====================================================
  Hits                          ?    60436           
  Misses                        ?    20397           
  Partials                      ?     4541           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed .

@@ Log scanner @@

remove-numNodes-trie-functionality

================================================================================

  • Known Warnings 6
  • New Warnings 1
  • Known Errors 0
  • New Errors 0
  • Panics 0
    ================================================================================
  • block hash does not match 1865
  • miniblocks does not match 0
  • miniblock hash does not match 0
  • receipts hash missmatch 0
  • wrong nonce in block 782
    ================================================================================
  • No jailed nodes on the thestnet
    ================================================================================

@iulianpascalau iulianpascalau merged commit 3c57b72 into feat/polaris-fixes Feb 24, 2023
@iulianpascalau iulianpascalau deleted the remove-numNodes-trie-functionality branch February 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants