Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.8-dev-config #4996

Merged
merged 1 commit into from
Feb 17, 2023
Merged

v1.4.8-dev-config #4996

merged 1 commit into from
Feb 17, 2023

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • compressed configs

Proposed changes

  • compressed configs

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov-commenter
Copy link

Codecov Report

Base: 70.80% // Head: 70.80% // No change to project coverage 👍

Coverage data is based on head (a1562fe) compared to base (c615368).
Patch has no changes to coverable lines.

❗ Current head a1562fe differs from pull request most recent head bba6df8. Consider uploading reports for the commit bba6df8 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4996   +/-   ##
=======================================
  Coverage   70.80%   70.80%           
=======================================
  Files         649      649           
  Lines       85356    85356           
=======================================
  Hits        60435    60435           
  Misses      20388    20388           
  Partials     4533     4533           
Impacted Files Coverage Δ
statusHandler/statusMetricsProvider.go 96.21% <0.00%> (-0.76%) ⬇️
common/pidQueue.go 96.66% <0.00%> (+3.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed

@iulianpascalau iulianpascalau merged commit bda270a into master Feb 17, 2023
@iulianpascalau iulianpascalau deleted the v1.4.8-dev-config branch February 17, 2023 13:34
@iulianpascalau iulianpascalau restored the v1.4.8-dev-config branch February 17, 2023 13:40
@iulianpascalau iulianpascalau added the ignore-for-release-notes Do not include item in release notes label Feb 17, 2023
@iulianpascalau iulianpascalau deleted the v1.4.8-dev-config branch May 13, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants