Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rc into feat refactor resolvers 2022.12.12 #4792

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

ssd04 and others added 30 commits May 27, 2022 15:42
- do not pass multisigner as parameter since it is not needed anymore
- no need to verify agg sig when created only with valid sigs
…n-on-consensus

Optimistic signature aggregation by leader
ssd04 and others added 21 commits December 6, 2022 13:04
…se-consensus-sigcheck

fixes after review: fix indentation + use timer in blacklist
…-consensus

Merge 1.5.0 feat optimize consensus
…ix-integration-tests

Fix integration tests
…igcheck

Feat/optimise consensus sigcheck
…-paths

added separate cli flag for db and logs path
…at_refactor_resolvers_2022.12.12

# Conflicts:
#	testscommon/components/default.go
@sstanculeanu sstanculeanu added the ignore-for-release-notes Do not include item in release notes label Dec 12, 2022
@sstanculeanu sstanculeanu self-assigned this Dec 12, 2022
@mariusmihaic mariusmihaic self-requested a review December 12, 2022 13:57
@codecov-commenter
Copy link

Codecov Report

Base: 70.79% // Head: 70.82% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (7edd46a) compared to base (69142e4).
Patch coverage: 75.29% of modified lines in pull request are covered.

❗ Current head 7edd46a differs from pull request most recent head b116331. Consider uploading reports for the commit b116331 to get more accurate results

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/refactor_resolvers    #4792      +/-   ##
===========================================================
+ Coverage                    70.79%   70.82%   +0.03%     
===========================================================
  Files                          655      657       +2     
  Lines                        84976    85321     +345     
===========================================================
+ Hits                         60159    60430     +271     
- Misses                       20286    20344      +58     
- Partials                      4531     4547      +16     
Impacted Files Coverage Δ
consensus/broadcast/commonMessenger.go 81.81% <ø> (ø)
consensus/spos/bls/constants.go 100.00% <ø> (ø)
factory/consensus/consensusComponents.go 0.00% <0.00%> (ø)
factory/crypto/cryptoComponents.go 0.00% <0.00%> (ø)
factory/crypto/cryptoComponentsHandler.go 0.00% <0.00%> (ø)
factory/crypto/signatureHolder.go 98.73% <ø> (ø)
node/nodeRunner.go 0.00% <0.00%> (ø)
consensus/spos/worker.go 82.55% <50.00%> (+0.56%) ⬆️
trie/dfsIterator.go 69.23% <69.23%> (ø)
consensus/spos/bls/blsWorker.go 94.11% <75.00%> (-2.66%) ⬇️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AdoAdoAdo AdoAdoAdo merged commit 5bf1d34 into feat/refactor_resolvers Dec 12, 2022
@AdoAdoAdo AdoAdoAdo deleted the merge_rc_into_feat_refactor_resolvers_2022.12.12 branch December 12, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants