Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.4.0 into cli for snapshots enabled #4763

Merged

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Dec 6, 2022

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

andreibancioiu and others added 23 commits November 28, 2022 13:18
…essed

index only non empty genesis miniblocks
…notifier

remove filtering for save block data
@ssd04 ssd04 added the ignore-for-release-notes Do not include item in release notes label Dec 6, 2022
@iulianpascalau iulianpascalau self-requested a review December 6, 2022 10:34
Copy link
Contributor

@iulianpascalau iulianpascalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usless PR? :D

@ssd04
Copy link
Contributor Author

ssd04 commented Dec 6, 2022

i've created it to run all tests easier :D

@ssd04 ssd04 merged commit 9a16d66 into cli-flag-for-snapshots-enabled Dec 6, 2022
@ssd04 ssd04 deleted the merge-1.4.0-into-cli-for-snapshots-enabled branch December 6, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.