Refactored private keys usage in consensus #4758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
reviewed
Dec 6, 2022
AdoAdoAdo
reviewed
Dec 6, 2022
consensus/interface.go
Outdated
| @@ -152,8 +152,8 @@ type ScheduledProcessor interface { | |||
| // SignatureHandler defines the behaviour of a component that handles signatures in consensus | |||
| type SignatureHandler interface { | |||
| Reset(pubKeys []string) error | |||
| CreateSignatureShare(msg []byte, index uint16, epoch uint32) ([]byte, error) | |||
| CreateSignatureShareWithPrivateKey(message []byte, index uint16, epoch uint32, privateKeyBytes []byte) ([]byte, error) | |||
| CreateSignatureShareUsingPublicKey(message []byte, index uint16, epoch uint32, publicKeyBytes []byte) ([]byte, error) | |||
There was a problem hiding this comment.
can you rename to CreateSignatureShareForPublicKey and CreateSignatureForPublicKey ?
There was a problem hiding this comment.
Renamed both methods to CreateSignatureShareForPublicKey and CreateSignatureForPublicKey
ssd04
approved these changes
Dec 6, 2022
Codecov ReportBase: 70.98% // Head: 70.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/multikey #4758 +/- ##
==============================================
Coverage 70.98% 70.99%
==============================================
Files 651 651
Lines 85415 85439 +24
==============================================
+ Hits 60634 60657 +23
+ Misses 20231 20228 -3
- Partials 4550 4554 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
AdoAdoAdo
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?