added p2p private key in crypto components #4674

ssd04 · 2022-11-07T21:45:07Z

Reasoning behind the pull request

Refactor p2p keys creation and management in order to have all crypto related components in one single place

Proposed changes

create p2p crypto components in crypto components factory, based on the newly added crypto suite (secp256k1 curve, ecdsa signing)
adapt seednode to use the new setup
refactor keygenerator to use the same generate key pattern

Testing procedure

Standard system test
Make sure the seeder and keygenerator works as before

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

…vate-key

…p2p-create-private-key Merge rc v1.4.0 refactor p2p create private key

codecov-commenter · 2022-11-15T11:26:44Z

Codecov Report

Base: 70.77% // Head: 70.71% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (5c069a7) compared to base (2da454c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@              Coverage Diff              @@
##           rc/v1.4.0    #4674      +/-   ##
=============================================
- Coverage      70.77%   70.71%   -0.06%     
=============================================
  Files            640      640              
  Lines          84329    84390      +61     
=============================================
  Hits           59680    59680              
- Misses         20176    20237      +61     
  Partials        4473     4473

Impacted Files	Coverage Δ
factory/crypto/cryptoComponents.go	`0.00% <0.00%> (ø)`
factory/crypto/cryptoComponentsHandler.go	`0.00% <0.00%> (ø)`
factory/network/networkComponents.go	`0.00% <0.00%> (ø)`
node/nodeRunner.go	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sstanculeanu · 2022-11-15T14:45:40Z

factory/crypto/cryptoComponents.go

@@ -105,6 +119,7 @@ func NewCryptoComponentsFactory(args CryptoComponentsFactoryArgs) (*cryptoCompon
 		importModeNoSigCheck:                 args.ImportModeNoSigCheck,
 		enableEpochs:                         args.EnableEpochs,
 		noKeyProvided:                        args.NoKeyProvided,
+		p2pKeyPemFileName:                    args.P2pKeyPemFileName,


perhaps add a check for len(args.P2pKeyPemFileName) == 0

the check was not added intentionally, so that if there is no file provided, a new key will be generated

sstanculeanu · 2022-11-15T14:47:25Z

factory/crypto/cryptoComponentsHandler.go

@@ -82,15 +82,24 @@ func (mcc *managedCryptoComponents) CheckSubcomponents() error {
 	if check.IfNil(mcc.cryptoComponents.publicKey) {
 		return errors.ErrNilPublicKey
 	}
+	if check.IfNil(mcc.cryptoComponents.p2pPublicKey) {
+		return errors.ErrNilPublicKey


should use different errors for p2pPublicKey and p2pPrivateKey

done, added

sstanculeanu · 2022-11-15T14:54:34Z

go.mod

@@ -5,9 +5,9 @@ go 1.15
 require (
 	github.com/ElrondNetwork/elastic-indexer-go v1.3.0
 	github.com/ElrondNetwork/elrond-go-core v1.1.24
-	github.com/ElrondNetwork/elrond-go-crypto v1.2.1
+	github.com/ElrondNetwork/elrond-go-crypto v1.2.2-0.20221110121517-4e85e482f854


don't forget proper releases

yup, proper release :D

cmd/keygenerator/main.go

common/configParser.go

iulianpascalau · 2022-11-16T07:44:16Z

go.mod

@@ -5,9 +5,9 @@ go 1.15
 require (
 	github.com/ElrondNetwork/elastic-indexer-go v1.3.0
 	github.com/ElrondNetwork/elrond-go-core v1.1.24
-	github.com/ElrondNetwork/elrond-go-crypto v1.2.1
+	github.com/ElrondNetwork/elrond-go-crypto v1.2.2-0.20221110121517-4e85e482f854


yup, proper release :D

iulianpascalau · 2022-12-09T06:43:59Z

go.mod

-	github.com/ElrondNetwork/wasm-vm-v1_4 v1.4.63
+	github.com/ElrondNetwork/elastic-indexer-go v1.3.3
+	github.com/ElrondNetwork/elrond-go-core v1.1.26
+	github.com/ElrondNetwork/elrond-go-crypto v1.2.3-0.20221207130836-796c2dff9ad7


do not forget about proper release here and on L10

added proper release tags

added p2p private key in crypto components

514ed85

ssd04 self-assigned this Nov 7, 2022

ssd04 added 6 commits November 8, 2022 10:36

seednode and tests fixes

16fa8de

Merge branch 'rc/v1.4.0' into merge-rc-v1.4.0-refactor-p2p-create-pri…

8e6f10a

…vate-key

Merge pull request #4701 from ElrondNetwork/merge-rc-v1.4.0-refactor-…

94069f9

…p2p-create-private-key Merge rc v1.4.0 refactor p2p create private key

update network components + fix tests and stubs

9fd1793

fix tests in node

c042d02

fix api integration test - set correct private key size in mock

5c069a7

ssd04 added 2 commits November 15, 2022 14:25

refactor p2p private key creation + fix seednode

63b899f

keygenerator: refactor to use the secp256k1 suite from crypto

68e6d39

ssd04 added area:libp2p impact:medium interested:tools interested:protocol type:refactoring labels Nov 15, 2022

ssd04 marked this pull request as ready for review November 15, 2022 13:02

sstanculeanu self-requested a review November 15, 2022 14:27

sstanculeanu reviewed Nov 15, 2022

View reviewed changes

iulianpascalau self-requested a review November 15, 2022 15:11

separate errors for p2p priv and public key

8de2d06

sstanculeanu previously approved these changes Nov 15, 2022

View reviewed changes

iulianpascalau reviewed Nov 16, 2022

View reviewed changes

moved creapteP2pKeyPair to crypto factory

b09ac91

ssd04 dismissed sstanculeanu’s stale review via b09ac91 November 16, 2022 07:51

ssd04 added 3 commits December 7, 2022 11:05

Merge branch 'rc/v1.4.0' into refactor-p2p-create-private-key

366df43

conflicts fix: update go.mod with latest crypto version

41990c1

update crypto and p2p with lastest changes

0cf0786

iulianpascalau reviewed Dec 9, 2022

View reviewed changes

gabi-vuls previously approved these changes Dec 9, 2022

View reviewed changes

gabi-vuls and others added 2 commits December 9, 2022 16:12

Merge branch 'rc/v1.4.0' into refactor-p2p-create-private-key

7a2187a

proper release for crypto and p2p

143d144

ssd04 dismissed gabi-vuls’s stale review via 143d144 December 9, 2022 14:58

iulianpascalau approved these changes Dec 9, 2022

View reviewed changes

sstanculeanu approved these changes Dec 9, 2022

View reviewed changes

gabi-vuls approved these changes Dec 9, 2022

View reviewed changes

ssd04 merged commit 9e63bd1 into rc/v1.4.0 Dec 9, 2022

ssd04 deleted the refactor-p2p-create-private-key branch December 9, 2022 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added p2p private key in crypto components #4674

added p2p private key in crypto components #4674

ssd04 commented Nov 7, 2022 •

edited

Loading

codecov-commenter commented Nov 15, 2022

sstanculeanu Nov 15, 2022

ssd04 Nov 15, 2022

sstanculeanu Nov 15, 2022

sstanculeanu Nov 15, 2022

ssd04 Nov 15, 2022

sstanculeanu Nov 15, 2022

iulianpascalau Nov 16, 2022

iulianpascalau Nov 16, 2022

iulianpascalau Dec 9, 2022

ssd04 Dec 9, 2022

ssd04 Dec 9, 2022 •

edited

Loading

added p2p private key in crypto components #4674

added p2p private key in crypto components #4674

Conversation

ssd04 commented Nov 7, 2022 • edited Loading

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

codecov-commenter commented Nov 15, 2022

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ssd04 Dec 9, 2022 • edited Loading

Choose a reason for hiding this comment

ssd04 commented Nov 7, 2022 •

edited

Loading

ssd04 Dec 9, 2022 •

edited

Loading