Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v1.4.0 feat optimise consensus sigcheck #4501

Conversation

ssd04
Copy link
Contributor

@ssd04 ssd04 commented Sep 22, 2022

Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)

  • Merge PR

Proposed Changes

  • Merge fixes: integrate signature handler component in consensus spos end subround

Testing procedure

  • N/A

bogdan-rosianu and others added 30 commits August 11, 2022 10:47
…ation-for-system-vm

EN-12707: improve sc generation for system vm calls
# Conflicts:
#	epochStart/bootstrap/syncValidatorStatus.go
#	errors/errors.go
#	factory/mock/coreComponentsMock.go
#	genesis/process/genesisBlockCreator.go
#	go.mod
#	heartbeat/process/monitor.go
#	integrationTests/testP2PNode.go
#	integrationTests/testProcessorNodeWithCoordinator.go
#	integrationTests/testProcessorNodeWithMultisigner.go
#	node/mock/factory/coreComponentsStub.go
#	process/block/preprocess/transactions.go
#	process/smartContract/hooks/blockChainHook.go
…-if-necessary

# Conflicts:
#	.github/workflows/build_and_test.yml
#	.github/workflows/code-coverage.yml
#	.github/workflows/create_release.yml
…tor-peers-mbs-11.08.2022

Merge dev into feat refactor peers mbs 11.08.2022
…a-proposer-side

# Conflicts:
#	epochStart/bootstrap/process.go
#	epochStart/bootstrap/storageProcess.go
#	epochStart/bootstrap/syncValidatorStatus.go
#	epochStart/errors.go
#	factory/processComponents.go
#	factory/shardingFactory.go
#	integrationTests/consensus/testInitializer.go
#	integrationTests/factory/consensusComponents/consensusComponents_test.go
#	integrationTests/factory/processComponents/processComponents_test.go
#	integrationTests/factory/statusComponents/statusComponents_test.go
#	integrationTests/nodesCoordinatorFactory.go
#	integrationTests/testHeartbeatNode.go
#	integrationTests/testP2PNode.go
#	integrationTests/testProcessorNode.go
#	integrationTests/testProcessorNodeWithCoordinator.go
#	integrationTests/testProcessorNodeWithMultisigner.go
#	node/nodeRunner.go
#	process/errors.go
#	process/factory/shard/preProcessorsContainerFactory.go
#	sharding/nodesCoordinator/errors.go
#	sharding/nodesCoordinator/indexHashedNodesCoordinator.go
#	sharding/nodesCoordinator/indexHashedNodesCoordinatorLite_test.go
#	sharding/nodesCoordinator/indexHashedNodesCoordinatorWithRater_test.go
#	sharding/nodesCoordinator/indexHashedNodesCoordinator_test.go
#	sharding/nodesCoordinator/shardingArgs.go
#	update/factory/exportHandlerFactory.go
#	update/sync/syncTransactions.go
change label name to ignore-for-release-notes
BeniaminDrasovean and others added 22 commits September 20, 2022 09:12
…pshot-nodes

# Conflicts:
#	node/nodeRunner.go
…ut-issue

Added request timeout for notifier http client
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	errors/errors.go
#	factory/bootstrap/bootstrapComponents.go
#	factory/bootstrap/bootstrapComponentsHandler.go
#	factory/consensus/consensusComponents.go
#	factory/consensus/consensusComponents_test.go
#	factory/core/coreComponents.go
#	factory/coreComponents_test.go
#	factory/crypto/cryptoComponents.go
#	factory/heartbeat/heartbeatComponents.go
#	factory/heartbeat/heartbeatV2Components.go
#	factory/heartbeatComponents_test.go
#	factory/networkComponents_test.go
#	factory/processComponents_test.go
#	factory/state/stateComponents.go
#	factory/stateComponents_test.go
#	integrationTests/consensus/testInitializer.go
#	integrationTests/factory/consensusComponents/consensusComponents_test.go
#	integrationTests/factory/processComponents/processComponents_test.go
#	integrationTests/factory/statusComponents/statusComponents_test.go
#	integrationTests/testProcessorNodeWithCoordinator.go
#	integrationTests/testProcessorNodeWithMultisigner.go
#	node/nodeRunner.go
#	process/errors.go
#	testscommon/mainFactoryMocks/bootstrapComponentsStub.go
# Conflicts:
#	cmd/node/config/enableEpochs.toml
#	config/epochConfig.go
#	config/tomlConfig_test.go
#	go.mod
#	go.sum
#	integrationTests/multiShard/smartContract/polynetworkbridge/bridge_test.go
#	node/nodeRunner.go
#	process/smartContract/process.go
#	process/smartContract/process_test.go
#	storage/factory/pruningStorerFactory.go
# Conflicts:
#	config/tomlConfig_test.go
#	factory/consensus/consensusComponents.go
@ssd04 ssd04 self-assigned this Sep 22, 2022
@ssd04 ssd04 added the ignore-for-release-notes Do not include item in release notes label Sep 22, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 73.43% // Head: 71.20% // Decreases project coverage by -2.22% ⚠️

Coverage data is based on head (04f84c3) compared to base (e479b28).
Patch coverage: 75.26% of modified lines in pull request are covered.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/optimise-consensus-sigcheck    #4501      +/-   ##
====================================================================
- Coverage                             73.43%   71.20%   -2.23%     
====================================================================
  Files                                   656      663       +7     
  Lines                                 85529    86039     +510     
====================================================================
- Hits                                  62804    61263    -1541     
- Misses                                17865    20268    +2403     
+ Partials                               4860     4508     -352     
Impacted Files Coverage Δ
common/forking/gasSchedule.go 75.82% <ø> (ø)
dataRetriever/txpool/argShardedTxPool.go 83.33% <ø> (ø)
facade/initial/initialNodeFacade.go 79.10% <0.00%> (ø)
factory/api/apiResolverFactory.go 0.00% <0.00%> (ø)
factory/bootstrap/bootstrapComponents.go 0.00% <0.00%> (ø)
factory/bootstrap/bootstrapComponentsHandler.go 0.00% <0.00%> (ø)
factory/bootstrap/bootstrapParameters.go 0.00% <ø> (ø)
factory/bootstrap/shardingFactory.go 0.00% <0.00%> (ø)
...actory/bootstrap/testBootstrapComponentsHandler.go 0.00% <0.00%> (ø)
factory/consensus/consensusComponents.go 0.00% <0.00%> (ø)
... and 174 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AdoAdoAdo AdoAdoAdo merged commit 41d4ff2 into feat/optimise-consensus-sigcheck Sep 23, 2022
@AdoAdoAdo AdoAdoAdo deleted the merge-v1.4.0-feat-optimise-consensus-sigcheck branch September 23, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.