Fix direct connections processor #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
added
type:bug
Codecov Report
@@ Coverage Diff @@
## rc/2022-july #4390 +/- ##
================================================
+ Coverage 73.78% 73.82% +0.03%
================================================
Files 675 675
Lines 86837 86853 +16
================================================
+ Hits 64072 64116 +44
+ Misses 17968 17939 -29
- Partials 4797 4798 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iulianpascalau
changed the title
iulianpascalau
changed the title
sstanculeanu
previously approved these changes
Aug 22, 2022
AdoAdoAdo
reviewed
Aug 23, 2022
| @@ -92,9 +98,22 @@ func (dcp *directConnectionsProcessor) startProcessLoop(ctx context.Context) { | |||
| } | |||
|
|
|||
| func (dcp *directConnectionsProcessor) sendMessageToNewConnections() { | |||
| if dcp.isCurrentNodeValidator() { | |||
| log.Debug("directConnectionsProcessor.sendMessageToNewConnections current node is validator, will not send send messages to connected peers") | |||
There was a problem hiding this comment.
double send in the message.
also is this method called for each connection? I think there will be too many logs for this.
There was a problem hiding this comment.
No, it will be logged once every 1 minute, as it is configured now
There was a problem hiding this comment.
fixed message
AdoAdoAdo
approved these changes
Aug 23, 2022
sstanculeanu
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure
*:DEBUG,heartbeat/processor:TRACE. If ran with this branch the sending will be done only on new connected peers.