Staking V4: auction list api endpoint #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabi-vuls
previously approved these changes
May 12, 2022
There was a problem hiding this comment.
System test passed.
@@ Log scanner @@
auction-list-api-endpoint
================================================================================
- Known Warnings 10
- New Warnings 2
- Known Errors 0
- New Errors 0
- Panics 0
================================================================================
mariusmihaic
previously approved these changes
May 12, 2022
| @@ -864,6 +864,10 @@ func (n *Node) ValidatorStatisticsApi() (map[string]*state.ValidatorApiResponse, | |||
| return n.processComponents.ValidatorsProvider().GetLatestValidators(), nil | |||
| } | |||
|
|
|||
| func (n *Node) AuctionListApi() ([]*common.AuctionListValidatorAPIResponse, error) { | |||
There was a problem hiding this comment.
Missing comment
Why do we need to return an error here?
| continue | ||
| } | ||
|
|
||
| pubKeyBytes, err := vp.validatorPubKeyConverter.Decode(pubKey) |
There was a problem hiding this comment.
could have extracted L120 - L138 in a function that could have returned error and do the error handling once.
Could have better tested the internal function on all cases
# Conflicts: # epochStart/metachain/systemSCs_test.go # factory/blockProcessorCreator.go
mariusmihaic
changed the base branch from
feat/liquid-staking
to
EN-12197-staking-v4-integration-tests-unJail
…ion-list-api-endpoint # Conflicts: # epochStart/metachain/auctionListSelector_test.go # epochStart/metachain/systemSCs_test.go # testscommon/stakingcommon/stakingDataProviderStub.go
mariusmihaic
approved these changes
Jun 10, 2022
iulianpascalau
approved these changes
Jun 10, 2022
…ion-list-api-endpoint
Base automatically changed from
EN-12197-staking-v4-integration-tests-unJail
to
feat/liquid-staking
June 16, 2022 11:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented the first version of the auction list API endpoint