Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fields query in transactions #1397

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Nov 27, 2024

Reasoning

Proposed Changes

  • add explode:false ApiQuery property to make sure that the values are serialized

How to test

  • go to local swagger
  • on transactions controller, add multiple values to fields API Query and the result should not return 500 InternalServer Error

Copy link

github-actions bot commented Nov 27, 2024

k6 load testing comparison.
Base Commit Hash: 9638379
Target Commit Hash: 6ba7465

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Nodes45.43590.8948.8350.4151.11658.9255.5257.56+12.49% 🔴+11.51% 🔴+13.69% 🔴+14.18% 🔴
Accounts46.02864.8048.8150.4651.861247.6655.5557.54+12.69% 🔴+44.27% 🔴+13.81% 🔴+14.02% 🔴
Mex45.05317.5348.8250.4450.58540.4155.5157.56+12.27% 🔴+70.19% 🔴+13.69% 🔴+14.12% 🔴
Pool45.57486.2448.8650.4151.06691.6155.5557.56+12.03% 🔴+42.24% 🔴+13.71% 🔴+14.18% 🔴
Tokens45.62578.0148.8450.4150.74420.5655.5057.55+11.23% 🔴-27.24% ✅+13.65% 🔴+14.15% 🔴
Blocks50.681167.3949.1851.4656.98990.6355.9559.53+12.43% 🔴-15.14% ✅+13.75% 🔴+15.68% 🔴
Transactions57.051631.8949.5551.4865.172352.0956.2860.30+14.24% 🔴+44.13% 🔴+13.59% 🔴+17.12% 🔴
Test Run Duration60002.1360004.17

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 self-assigned this Nov 27, 2024
@cfaur09 cfaur09 added the bugfix Fix something that isn't working correctly label Nov 27, 2024
@cfaur09 cfaur09 merged commit 5cf7be0 into development Nov 27, 2024
5 checks passed
@cfaur09 cfaur09 deleted the API-101-fix-fields-query-param-for-transactions branch November 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix something that isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants