Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new nft types #1300

Merged
merged 12 commits into from
Aug 7, 2024
Merged

Conversation

tanghel
Copy link
Contributor

@tanghel tanghel commented Aug 6, 2024

Reasoning

  • In the upcoming protocol release, we have additional NFT collection types related to dynamic NFTs and NFT v2, which need accomodation at api level

Proposed Changes

  • In order to make the transition as smooth as possible and avoid breaking all dapps that perform queries on the collections and nfts endpoints, the new types are mapped on the existing types NonFungibleESDT, SemiFungibleESDT and MetaESDT, with a subType attribute differentiating the new types

How to test (testnet)

  • /collections should return also collections of subType NonFungibleESDTv2
  • /collections?type=NonFungibleESDT should return also collections of subType NonFungibleESDTv2
  • /nfts should return also NFTs of subType NonFungibleESDTv2
  • /nfts?type=NonFungibleESDT should return also NFTs of subType NonFungibleESDTv2
  • /nfts/TEST-41f2aa-01 should have type NonFungibleESDT and subType NonFungibleESDTv2
  • /accounts/erd1e7qgngs0sq2f9fkyqa0ddvy52a66t6yrv9jd09afrn9cqm0lc4cquhm7ug/nfts should return also NFTs of subType NonFungibleESDTv2
  • /accounts/erd1e7qgngs0sq2f9fkyqa0ddvy52a66t6yrv9jd09afrn9cqm0lc4cquhm7ug/nfts/TEST-41f2aa-01 should return the NFT of type NonFungibleESDTv2

gabrielmatei
gabrielmatei previously approved these changes Aug 6, 2024
@cfaur09 cfaur09 added the feature New feature or request label Aug 7, 2024
@tanghel tanghel merged commit f4e6283 into development Aug 7, 2024
2 checks passed
@tanghel tanghel deleted the SERVICES-2528-support-for-new-nft-types branch August 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants