Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logs & scResults for transfers #1283

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Jun 11, 2024

Proposed Changes

  • added new query options for transfers: withLogs & withScResults
  • added above query options to all /transfers routes

How to test

  • accounts/erd13ejcgw5p09pdphy7qjyvmldwl6hd5d86zssp88v7fkfn4kskt3rq040wf7/transfers?size=1&withLogs=true
  • accounts/erd13ejcgw5p09pdphy7qjyvmldwl6hd5d86zssp88v7fkfn4kskt3rq040wf7/transfers?size=1&withLogs=false
  • accounts/erd13ejcgw5p09pdphy7qjyvmldwl6hd5d86zssp88v7fkfn4kskt3rq040wf7/transfers?withScResults=true
  • accounts/erd13ejcgw5p09pdphy7qjyvmldwl6hd5d86zssp88v7fkfn4kskt3rq040wf7/transfers?withScResults=false
  • accounts/erd13ejcgw5p09pdphy7qjyvmldwl6hd5d86zssp88v7fkfn4kskt3rq040wf7/transfers?withLogs=true&withScResults=true
  • transfers?size=50&withLogs=true
  • transfers?size=51&withLogs=true -> complexity exceeded
  • transfers?withLogs=true
  • transfers?size=50&withScResults=true
  • transfers?size=51&withScResults=true -> complexity exceeded
  • transfers?withScResults=true

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.65%. Comparing base (ecf9f53) to head (d3b7143).
Report is 176 commits behind head on development.

Current head d3b7143 differs from pull request most recent head ce627fb

Please upload reports for the commit ce627fb to get more accurate results.

Files Patch % Lines
src/endpoints/transfers/transfer.service.ts 0.00% 3 Missing and 1 partial ⚠️
src/endpoints/accounts/account.controller.ts 0.00% 1 Missing ⚠️
src/endpoints/transfers/transfer.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           development    #1283       +/-   ##
================================================
- Coverage        63.99%   46.65%   -17.35%     
================================================
  Files              576      614       +38     
  Lines            14895    16385     +1490     
  Branches          1525     1767      +242     
================================================
- Hits              9532     7644     -1888     
- Misses            4021     7050     +3029     
- Partials          1342     1691      +349     
Flag Coverage Δ
integrationtests ?
unittests 46.65% <0.00%> (+12.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanghel tanghel added the feature New feature or request label Jun 20, 2024
@tanghel tanghel merged commit 99b2ae9 into development Jun 20, 2024
1 of 2 checks passed
@tanghel tanghel deleted the SERVICES-2451-add-logs-and-results-for-transfers branch June 20, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants