Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default icons for exchange contracts #1250

Merged
merged 1 commit into from
May 20, 2024
Merged

add default icons for exchange contracts #1250

merged 1 commit into from
May 20, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented May 14, 2024 •
edited
Loading

Reasoning

  • We need to add these fields for every exchange contract.
  • These fields will be used by the frontend (explorer, wallet) to display appropriate icons for the exchange contracts.

Proposed Changes

  • To avoid repetitive code when setting iconSvg and iconPng for AccountAssets created a helper function to set AccountAssets fields
  • Add for every exchange contract iconSvg and iconPng

How to test

  • accounts/erd1qqqqqqqqqqqqqpgqvc7gdl0p4s97guh498wgz75k8sav6sjfjlwqh679jy -> check if assets contains also icons

@cfaur09 cfaur09 mentioned this pull request May 14, 2024
Closed
@cfaur09 cfaur09 self-assigned this May 14, 2024
@cfaur09 cfaur09 added feature New feature or request refactoring The same functionality is maintained, but in an improved way labels May 14, 2024
@tanghel tanghel merged commit 46bfe22 into development May 20, 2024
2 of 3 checks passed
@tanghel tanghel deleted the SERVICES-2366-add-default-icons-for-exchange-contract branch May 20, 2024 12:37
IosifGabriel pushed a commit to buidly/mvx-api that referenced this pull request May 22, 2024
@cfaur09 @IosifGabriel
add default icons for exchange contracts (multiversx#1250)
899e345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanghel tanghel tanghel approved these changes

@danielailie danielailie danielailie approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@cfaur09 cfaur09

Labels
feature New feature or request refactoring The same functionality is maintained, but in an improved way
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfaur09 @tanghel @danielailie @bogdan-rosianu