Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward index endpoints #1223

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Forward index endpoints #1223

merged 4 commits into from
Mar 26, 2024

Conversation

tanghel
Copy link
Contributor

@tanghel tanghel commented Mar 26, 2024

Proposed Changes

  • To ease with debugging, offer the possibility to access the ES instance that sits behind the api

How to test

  • GET /index/logs/_search should return logs
  • GET /index/logs/_count should return logs count
  • POST /index/logs/_search should return logs with query params set in body
  • POST /index/logs/_count should return logs count with query params set in body

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 46.34%. Comparing base (d5dc553) to head (2e7bd61).
Report is 1 commits behind head on development.

Files Patch % Lines
src/endpoints/proxy/index.proxy.controller.ts 44.00% 14 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1223      +/-   ##
===============================================
- Coverage        46.36%   46.34%   -0.02%     
===============================================
  Files              593      594       +1     
  Lines            15782    15834      +52     
  Branches          1685     1687       +2     
===============================================
+ Hits              7318     7339      +21     
- Misses            6842     6871      +29     
- Partials          1622     1624       +2     
Flag Coverage Δ
unittests 46.34% <53.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bogdan-rosianu
bogdan-rosianu previously approved these changes Mar 26, 2024
gabrielmatei
gabrielmatei previously approved these changes Mar 26, 2024
@tanghel tanghel dismissed stale reviews from gabrielmatei and bogdan-rosianu via 2e7bd61 March 26, 2024 13:17
@tanghel tanghel merged commit 2e3db69 into development Mar 26, 2024
4 of 5 checks passed
@tanghel tanghel deleted the forward-index branch March 26, 2024 13:28
@cfaur09 cfaur09 added the feature New feature or request label Mar 26, 2024
IosifGabriel pushed a commit to buidly/mvx-api that referenced this pull request May 22, 2024
* proxy endpoints for index

* renamed proxy controller to gateway proxy controller

* removed endpoints in gateway controller

* implemented error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants