Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pool controller specs #1213

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Mar 1, 2024

Proposed Changes

  • Add new tests for pool.controller.ts

How to test

  • npm run test -> all tests should pass

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.96%. Comparing base (0ad8e13) to head (2d7cd45).

❗ Current head 2d7cd45 differs from pull request most recent head 6d6d294. Consider uploading reports for the commit 6d6d294 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1213      +/-   ##
===============================================
+ Coverage        45.92%   45.96%   +0.03%     
===============================================
  Files              591      591              
  Lines            15568    15568              
  Branches          1641     1641              
===============================================
+ Hits              7150     7156       +6     
+ Misses            6837     6831       -6     
  Partials          1581     1581              
Flag Coverage Δ
unittests 45.96% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfaur09 cfaur09 self-assigned this Mar 1, 2024
@cfaur09 cfaur09 merged commit 8543629 into development Mar 1, 2024
3 checks passed
@cfaur09 cfaur09 deleted the SERVICES-2182-add-pool-controller-specs branch March 1, 2024 13:08
@tanghel tanghel added the test Create or update unit / integration tests label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Create or update unit / integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants