Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep history for vm query #1200

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Deep history for vm query #1200

merged 2 commits into from
Feb 20, 2024

Conversation

tanghel
Copy link
Contributor

@tanghel tanghel commented Feb 12, 2024

Proposed Changes

  • extend deep history gateway support for the /vm-values/query endpoint

How to test

  • perform query to the /query or the /vm-values/query endpoints with timestamp parameter. The response headers should return the block nonce corresponding to the provided timestamp in the shard of the scAddress parameter

@tanghel tanghel changed the base branch from main to development February 12, 2024 15:52
gabrielmatei
gabrielmatei previously approved these changes Feb 12, 2024
bogdan-rosianu
bogdan-rosianu previously approved these changes Feb 12, 2024
@cfaur09 cfaur09 dismissed stale reviews from bogdan-rosianu and gabrielmatei via 700848d February 13, 2024 12:40
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a78635) 39.11% compared to head (700848d) 39.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development    #1200   +/-   ##
============================================
  Coverage        39.11%   39.11%           
============================================
  Files                9        9           
  Lines              317      317           
  Branches            19       19           
============================================
  Hits               124      124           
  Misses             174      174           
  Partials            19       19           
Flag Coverage Δ
unittests 39.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanghel tanghel merged commit c735c55 into development Feb 20, 2024
5 of 7 checks passed
@tanghel tanghel deleted the deep-history-for-vm-query branch February 20, 2024 11:14
@tanghel tanghel added the feature New feature or request label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants