Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function setElementLighting #3905

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

FileEX
Copy link
Contributor

@FileEX FileEX commented Dec 24, 2024

This PR adds the setElementLighting function, which allows setting custom lighting for a specific element.

@tederis tederis merged commit 90fd98a into multitheftauto:master Dec 25, 2024
6 checks passed
@FileEX FileEX deleted the feature/setElementLighting branch December 25, 2024 07:39
@Fernando-A-Rocha
Copy link
Contributor

Can u showcase this in action?

@FileEX
Copy link
Contributor Author

FileEX commented Dec 25, 2024

Can u showcase this in action?

I don't think there's much to show here. You can simply adjust the brightness of elements like peds, vehicles, or objects

@Fernando-A-Rocha
Copy link
Contributor

Can u showcase this in action?

I don't think there's much to show here. You can simply adjust the brightness of elements like peds, vehicles, or objects

Ah I think a more appropriate name would be
setElementLightBrightness or setElementLightIntensity ?

@FileEX
Copy link
Contributor Author

FileEX commented Dec 25, 2024

Can u showcase this in action?

I don't think there's much to show here. You can simply adjust the brightness of elements like peds, vehicles, or objects

Ah I think a more appropriate name would be setElementLightBrightness or setElementLightIntensity ?

This function is the missing counterpart to getElementLighting. The names of these functions can be changed if someone wants, and the current ones can be marked as deprecated, although I think these names are ok

@tederis
Copy link
Member

tederis commented Dec 25, 2024

I agree with the FileEX's arguments. setElementLighting and getElementLighting deal with the same value. And if someone wants to change a function's name then it must be applied to both functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants