-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "flyingcomponents" special world property #3597
Add "flyingcomponents" special world property #3597
Conversation
flyingcomponents special world property
Again I'll have to point out that this to me seems like more of a bug-fix-scenario, rather than a special-world-property-scenario. What about the current behavior is desirable? |
Probably nothing, but it's better to set it to the current default than for the PR to get labeled as 'backwards-incompatible' and end up stalled for several months, or possibly even years |
It won't. Current state is bugged |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed defaults in the sync structures where you used false
instead of true
for this new special world property.
Merge after #3572
This PR adds a new special world property called
flyingcomponents
(default is true). This property determines whether the detached components such as doors, bumpers, etc., should respawn after a vehicle is recreated or streamed in. This PR solves a very frustrating and annoying issue where all missing components fall off again after usingsetElementModel
orsetVehicleVariant
:Thanks to this property, various car garages and vehicle spawners will be able to look normal without flying components around