Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/protocol.rs: Add /webtransport #70

Merged
merged 3 commits into from
Dec 16, 2022
Merged

src/protocol.rs: Add /webtransport #70

merged 3 commits into from
Dec 16, 2022

Conversation

jxs
Copy link
Contributor

@jxs jxs commented Dec 9, 2022 •
edited
Loading

addresses #68

mxinden
mxinden reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing update to Arbitrary implementation. See also #65.

Otherwise this looks good to me. Thanks @jxs!

jxs
jxs commented Dec 15, 2022
View reviewed changes
Copy link
Contributor Author

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max, updated!

mxinden
mxinden reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this looks good to me. Thanks.

CHANGELOG.md
@@ -1,3 +1,9 @@
# 0.18.0 [unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version bump in Cargo.toml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry Max! Updated

mxinden
mxinden approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thanks!

@mxinden mxinden merged commit 2a754e2 into multiformats:master Dec 16, 2022
@jxs jxs mentioned this pull request Dec 17, 2022
Closed
@mxinden mxinden mentioned this pull request Dec 20, 2022
Merged
oblique pushed a commit to oblique/rust-multiaddr that referenced this pull request Jun 3, 2023
@jxs @oblique
src/protocol.rs: Add /webtransport (multiformats#70)
a54e205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxs @mxinden