chore: Make @jacobheun the lead maintainer #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This was triggered by: #78 (comment) |
vmx
force-pushed
the
change-lead-maintainer
branch
from
48f05d4 to
eb4b54a
Compare
|
Sounds good. I'm OK with it as long as @jacobheun is OK with it :) |
victorb
approved these changes
Jan 28, 2019
|
@daviddias Tech lead, please approve :) |
daviddias
approved these changes
Jan 28, 2019
daviddias
requested changes
Jan 28, 2019
There was a problem hiding this comment.
Missing to update https://github.com/multiformats/js-multiaddr/blob/master/package.json#L5
|
Meanwhile, already gave @jacobheun publish perms |
vmx
force-pushed
the
change-lead-maintainer
branch
from
eb4b54a to
1a6f1ae
Compare
|
Good catch @daviddias, it's fixed now. |
daviddias
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would make sense to hand the lead maintainership over to someone from the libp2p team, I propose @jacobheun.
What do you think @victorb?
Once approved my @victorb (current lead maintainer) and @daviddias (tech lead) I'll add jacob as maintainer to npm and will remove myself.