Export reserved range constants

[rvagg]

No description provided.

[rvagg]

OK, well that's not as easy as it seems, stringer is pull those out as if they were codes, see https://github.com/multiformats/go-multicodec/runs/3132456370?check_suite_focus=true

@mvdan what's the intention here? I've committed the build version, see cd32040, is this appropriate for these values given that they're not truly codecs, but meant to be simple constants. Is it OK that they get tangled up in the generated stuff?

[mvdan]

Hmm, yeah, it's not great to expose these with names as if they were registered codes.

How about making them untyped constants, like const Foo = 123? Then stringer won't pick them up.

They'll lack the Code type, but I think that's right - they are not codes. They are simply helpful constants. And, since they are untyped Go constants, they can be converted to any integer type easily, including Code.

[mvdan]

SGTM if you drop the type and re-generate

[rvagg]

cool, dropped the Code and it's much nicer, fixed up nits

[mvdan]

SGTM! I assume you'll squash-merge?

[rvagg]

I assume you'll squash-merge?

Assume nothing! Keeping up with people's preferences around commits is tricky and I find Go git preferences to be quite different to JS so I use git history to make a guess about style. I'm not really sure what to make of the git history here though.

Will squash.