make Multiaddr a newtype of []bytes #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to send multiaddrs on the wire without copying (through the `Bytes()` method). It also avoids one allocation/indirection per multiaddr. This is an alternative (or stop-gap) to #62 as #62 is invasive. Unlike #62, this PR doesn't break `Multiaddr == nil` or `maddr1.Equals(maddr2)`. However, it *doesn't* allow multiaddrs to be used as map keys :(.
| @@ -215,12 +215,6 @@ func TestBytesSplitAndJoin(t *testing.T) { | |||
| t.Errorf("joined components failed: %s != %s", m, joined) | |||
| } | |||
|
|
|||
| // modifying underlying bytes is fine. | |||
| m2 := m.(*multiaddr) | |||
| for i := range m2.bytes { | |||
There was a problem hiding this comment.
could change this to just directly modify m2. I think the check is still valuable.
There was a problem hiding this comment.
No, this is actually broken, that's why I removed it. I'm no longer copying on Split, just slicing. I'm now assuming that multiaddrs are immutable. I'm not entirely sure why we had this test in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to send multiaddrs on the wire without copying (through the
Bytes()method). It also avoids one allocation/indirection per multiaddr.This is an alternative (or stop-gap) to #62 as #62 is invasive. Unlike #62, this PR doesn't break
Multiaddr == nilormaddr1.Equals(maddr2). However, it doesn't allow multiaddrs to be used as map keys :(.Motivation: Make the allocate less when reporting closer peers. That's currently one of our largest sources of ephemeral byte slice allocations.