Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Local Address on TCP connections #135

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix Local Address on TCP connections #135

merged 1 commit into from
Jan 22, 2021

Conversation

aarshkshah1992
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 mentioned this pull request Jan 21, 2021
Closed
23 tasks
@willscott
Copy link
Contributor

it seems somewhat awkward that the laddr on the listener is different from the local address that's actually used on connections. Is the issue that there can be multiple potential local addresses for a single listener?

@Stebalien
Copy link
Member

it seems somewhat awkward that the laddr on the listener is different from the local address that's actually used on connections. Is the issue that there can be multiple potential local addresses for a single listener?

Yes. E.g., we could be listening on the "zero" address.

@aarshkshah1992 aarshkshah1992 merged commit 7274874 into master Jan 22, 2021
@aarshkshah1992 aarshkshah1992 deleted the feat/fix-local-addr branch January 22, 2021 07:46
@aarshkshah1992 aarshkshah1992 mentioned this pull request Jan 27, 2021
Merged
1 task
@marten-seemann marten-seemann mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local connection address should not be an unspecified address
3 participants
@aarshkshah1992 @willscott @Stebalien