This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
Add IsLocalAddr helper #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
reviewed
Jun 13, 2019
| // Private4 and Private6 are well-known private networks | ||
| var Private4, Private6 []*net.IPNet | ||
| var privateCIDR4 = []string{ | ||
| // Private4, Private6, Local4, and Local6 are well-known private networks |
There was a problem hiding this comment.
Suggest breaking this down into two declarations and contextualising godoc.
| // localhost | ||
| "127.0.0.0/8", | ||
| // link local | ||
| "169.254.0.0/16", |
There was a problem hiding this comment.
I think it’s ok moving link locals here. I struggle to find a use case where these would be useful, but maybe I’m missing something, @Stebalien?
| @@ -47,6 +55,10 @@ var unroutableCIDR6 = []string{ | |||
| } | |||
|
|
|||
| func init() { | |||
| privateCIDR4 = append(privateCIDR4, localCIDR4...) | |||
There was a problem hiding this comment.
This is confusing. Could you move the append to the declaration? Also, does it make sense to keep locals here?
| switch c.Protocol().Code { | ||
| case ma.P_IP6ZONE: | ||
| return true | ||
| default: |
| return true | ||
| default: | ||
| return false | ||
| case ma.P_IP4: |
There was a problem hiding this comment.
IPv4 is the hot path, so let’s make it the first one, then IPv6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for libp2p/go-libp2p#657