WIP, MAINT: selective OSX deploy target #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only overwrite MACOSX_DEPLOYMENT_TARGET environment variable when it contains the "10.x" version string * motivation is to allow sensibel overrides as in: MacPython/scipy-wheels#150 * note that I have not tested this yet, but am open to making revisions of course
isuruf
reviewed
Dec 8, 2021
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
|
@matthew-brett any comments on this one? do you want me to just try this feature branch from my fork alongside the cross-listed SciPy wheels PR to see if it works, or is this simple/straightforward enough as-is? |
|
Am I right in thinking that the intention is to make the MACOSX_DEPLOYMENT_TARGET at least 11.0 ? Maybe add a comment to that effect? |
|
Yeah, at least 11 with the option to manually override for projects that don't work with 11, etc. Ok, will try to adjust the commenting |
* add a comment clarifying that MACOSX_DEPLOYMENT_TARGET is set to "at least 11.0" for arm64 Mac
|
Ok, I took a stab at adding another clarifying comment related to that. |
tylerjereddy
added a commit
to tylerjereddy/scipy-wheels
that referenced
this pull request
Dec 9, 2021
* point to the multibuild feature branch here: multi-build/multibuild#446 * trying to see if this will allow override of the MACOSX_DEPLOYMENT_TARGET as intended
tylerjereddy
added a commit
to tylerjereddy/scipy-wheels
that referenced
this pull request
Dec 9, 2021
* point to the multibuild feature branch here: multi-build/multibuild#446 * trying to see if this will allow override of the MACOSX_DEPLOYMENT_TARGET as intended
|
This isn't working yet, see: MacPython/scipy-wheels#150 (comment) For now, I'll likely continue with a custom wheel renaming solution downstream in SciPy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only overwrite MACOSX_DEPLOYMENT_TARGET environment
variable when it contains the "10.x" version string
motivation is to allow sensibel overrides as in:
WIP, MAINT: MacOS wheels 12.0 target MacPython/scipy-wheels#150
note that I have not tested this yet, but am open
to making revisions of course
cc @isuruf @rgommers