Adapt to new never type fallback by explicitly stating unit types #6352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serock3
reviewed
Jun 14, 2024
Serock3
reviewed
Jun 14, 2024
Serock3
reviewed
Jun 14, 2024
faern
force-pushed
the
fix-never-type-fallback-warning-des-1041
branch
from
e775dcb to
9592f40
Compare
faern
force-pushed
the
fix-never-type-fallback-warning-des-1041
branch
from
9592f40 to
26b2751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is for the never type to be stabilized in Rust 2024 (:partying_face: YAY, finally!). But for that to happen some of the current automatic fallback from never (
!) to unit (()) must be changed. And as a result any code relying on the current fallback to unit behavior must be changed to not rely on this automatic fallback, but rather be explicit unit type.This PR fixes the two instances we had of this automatic fallback, as pointed out by the latest nightly compiler.
The tracking issue for never types: rust-lang/rust#123748
This change is