Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore check prefixes at the ends of words #149

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

tlively
Copy link
Contributor

@tlively tlively commented Nov 17, 2020

Ignore check prefixes that are actually the ends of longer words. For example, a
line containing "NO-CHECK:" should not be interpreted as containing a "CHECK:"
directive. A check prefix is considered to be the end of a longer word if there
is a character before it on the same line and that character is alphanumeric,
"_", or "-", just like in upstream FileCheck.

Ignore check prefixes that are actually the ends of longer words. For example, a
line containing "NO-CHECK:" should not be interpreted as containing a "CHECK:"
directive. A check prefix is considered to be the end of a longer word if there
is a character before it on the same line and that character is alphanumeric,
"_", or "-", just like in upstream FileCheck.
@tlively
Copy link
Contributor Author

tlively commented Nov 17, 2020

Hi! Thanks for putting this package together. We're about to start using it for running some of our tests for https://github.com/webassembly/binaryen. I don't think we'll need many of the more advanced FileCheck features that aren't yet implemented here, but I've found the capability in this PR useful in upstream LLVM. The other very useful feature I expect to want eventually is the --check-prefixes=<prefix1>,<prefix2> to enable multiple prefixes at once. I'll probably make another PR adding that functionality when I need it.

filecheck/FileCheck.py Outdated Show resolved Hide resolved
@stanislaw
Copy link
Member

Hi! Thanks for putting this package together. We're about to start using it for running some of our tests for https://github.com/webassembly/binaryen. I don't think we'll need many of the more advanced FileCheck features that aren't yet implemented here, but I've found the capability in this PR useful in upstream LLVM. The other very useful feature I expect to want eventually is the --check-prefixes=<prefix1>,<prefix2> to enable multiple prefixes at once. I'll probably make another PR adding that functionality when I need it.

We are glad that you find this package useful. Thank you for your contributions. The --check-prefixes was one of the next items on my todo list - I would be happy to accept a PR.

@stanislaw stanislaw merged commit f462731 into mull-project:master Nov 17, 2020
@tlively tlively deleted the is-part-of-word-check branch November 17, 2020 22:13
tlively added a commit to tlively/binaryen that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants