Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update raml-1-parser to newer version #157

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Update raml-1-parser to newer version #157

merged 1 commit into from
Feb 23, 2018

Conversation

danielwpz
Copy link
Contributor

@danielwpz danielwpz commented Feb 23, 2018

raml-1-parser older than 1.1.40 is using marked older than 0.3.7, which has a vulnerability that could enable XSS attack. (markedjs/marked#844).

We are not directly affected by this bug and the latest raml-1-parser has removed marked from their dependencies. But it is worthy to bump the version so that we are specifically using a newer dependency.

@coveralls
Copy link

coveralls commented Feb 23, 2018

Coverage Status

Coverage remained the same at 97.25% when pulling 4ecc22f on marked into 3db55eb on master.

@jstoiko
Copy link
Contributor

jstoiko commented Feb 23, 2018

@danielwpz: this dependency is referenced using caret ranges. Also, as I pointed out in my PR on the parser, the marked dependency is not used anywhere in the code of the parser, it is used for documentation generation purpose only.

Thanks for the PR anyway, we'll merge it whenever we release a new version of Osprey.

@danielwpz
Copy link
Contributor Author

@jstoiko hey thanks for the timely reply! In practice, you're absolutely right, but using a vulnerable dependency will prevent osprey from passing lots of security scanning. Since we are aware of this, there is no reason why not just update the dep :)

@jstoiko
Copy link
Contributor

jstoiko commented Feb 23, 2018

Not sure what "security scanning" you are referring to but if I install Osprey now, it does install raml-1-parser@1.1.40 and doesn't even install marked since it was removed from the dependencies of the RAML parser. That's the benefit of using caret ranges to define dependencies.

$ npm I osprey
+ osprey@0.4.1
added 205 packages in 8.683s

$ npm list | grep raml-1-parser
  ├─┬ raml-1-parser@1.1.40

$ npm list | grep marked

@danielwpz danielwpz merged commit f2372b7 into master Feb 23, 2018
@danielwpz danielwpz deleted the marked branch February 23, 2018 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants