This repository was archived by the owner on Jan 21, 2024. It is now read-only.
Better handling of custom vnd media types #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be able to generate a valid Java method name for 'application/octet-stream' (which was generating e.g. octet-streamOK)
|
It's in progress. We are merging the projects. Please check: URL to the temp one https://github.com/usarid/RAML-for-JAX-RS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
getShortMimeTypegenerates names that are not valid as Java identifier so it's basically impossible to use custom vnd. media types with the generator.I've added unit tests as well, first to capture the current behaviour, proves it doesn't change then test the new behaviour.
This PR builds on #32 which is supposed to be pulled.