Fixed plugin crash and add libraries #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the recent commit, there was a full dispose that caused the WeavePreviewComponent not being able to be reused. This causes plugin crash in the IDE when opening the Dataweave preview. The proposed solution is to recreate the WeavePreviewComponent when setting a new DWL file, because WeavePreviewComponent is always in a disposed state at this time. In a dataweave that has java import for classes that live in a library, the Dataweave preview complains that it cannot find the class file. The proposed solution is to send all libraries, except SDK, to the agent so that the class file is available when the script engine evaluates the Dataweave in the agent.
machaval
reviewed
Jul 3, 2024
| @@ -150,6 +150,7 @@ private void setFile(@Nullable PsiFile psiFile) { | |||
| mainPanel.remove(previewComponent); | |||
| previewComponent = null; | |||
| } | |||
| weavePreviewComponent = new WeavePreviewComponent(myProject); | |||
There was a problem hiding this comment.
Shouldn't we only re-created if it is disposed? Shouldn't we check that
There was a problem hiding this comment.
Good point, I'll add a check.
There was a problem hiding this comment.
A check was added in the latest commit.
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Abi Harbani <a***@g***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated. |
Perform an isDisposed check before recreating weavePreviewComponent
abiharbani
force-pushed
the
ah_fixWeavePreviewCannotOpen
branch
from
d4b576e to
0d03c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent commit, there was a full dispose that caused the WeavePreviewComponent not being able to be reused. This causes plugin crash in the IDE when opening the Dataweave preview. The proposed solution is to recreate the WeavePreviewComponent when setting a new DWL file, because WeavePreviewComponent is always in a disposed state
at this time.
In a dataweave that has java import for classes that live in a library, the Dataweave preview complains that it cannot find the class file. The proposed solution is to send all libraries, except SDK, to the agent so that the class file is available when the script engine evaluates the Dataweave in the agent.