-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.7.2 release #85
V2.7.2 release #85
Conversation
|
||
rowIndex++; | ||
progress?.Report(1); | ||
} | ||
} | ||
|
||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that you need to work with such a patch...
Was it already here before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shared some details on your issue ticket, I believe the timestamp field is malformed which is why it's being shown as a epoch value instead of datetime.
I added a patch so we can still open such fields in the app for now. These types of inconsistencies tend to get resolved over time so I'm hoping that will be the case with this issue. I added a unit test to detect this as well.
We used to handle timestamp fields directly in the app but the parquet-dotnet
library had added support for internally handling DateTime fields so we got rid of the logic from the app. But if the metadata is malformed of course that library doesn't handle it as a DateTime. So I added the old logic back for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I am wondering which package doesn't write away the metadata correctly.
It's made with pandas
, but that is juste a wrapper to pyarrow
- the python implementation of Apache Arrow
, a package from the creators of Apache Parquet
.
So strange... or it's on the parquet-dotnet
side.
I'll see if I need to open another bug somewhere else.
Thanks
Summary
This version:
One other thing of note is how the analytics opt-in logic works. If you didn't accept to opt-in, the app doesn't ask you again until you upgrade to a newer version 🙃 So don't be surprised if you see that message again.