Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove profile.Version() and export Version constant instead #173

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

muktihari
Copy link
Owner

Remove Version() and export the Version constant directly, so we can retrieve the version at compile time.

@muktihari muktihari added the enhancement New feature or request label Apr 10, 2024
@muktihari muktihari self-assigned this Apr 10, 2024
@muktihari muktihari changed the title fix: remove Version() and export Version constant fix: remove profile.Version() and export Version constant Apr 10, 2024
@muktihari muktihari changed the title fix: remove profile.Version() and export Version constant fix: remove profile.Version() and export Version constant instead Apr 10, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fe073c) to head (ec52799).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3471      3471           
=========================================
  Hits          3471      3471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 50cc763 into master Apr 10, 2024
4 checks passed
@muktihari muktihari deleted the fix/export-profile-version-constant branch April 10, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants