fix: mesgdef should clear array pool directly (#479)

* fix: mesgdef should clear array pool directly * fitgen: generate mesgdef
muktihari · Oct 4, 2024 · 405d6b0 · 405d6b0
1 parent b85b163
commit 405d6b0
Show file tree

Hide file tree

Showing 120 changed files with 240 additions and 240 deletions.
diff --git a/internal/cmd/fitgen/profile/mesgdef/mesgdef.tmpl b/internal/cmd/fitgen/profile/mesgdef/mesgdef.tmpl
@@ -68,7 +68,7 @@ func New{{ .Name }}(mesg *proto.Message) *{{ .Name }} {
 			vals[mesg.Fields[i].Num] = mesg.Fields[i].Value
 		}
 		unknownFields = sliceutil.Clone(unknownFields)
-		clear(arr[:len(unknownFields)]) {{/* In case of unknown field or field.Value contains pointer to a slice */}}
+		*arr = [poolsize]proto.Field{} {{/* In case of unknown field or field.Value contains pointer to a slice */}}
 		pool.Put(arr)
 		{{- if and (not (eq .Name "FileId")) (not (eq .Name "DeveloperDataId")) (not (eq .Name "FieldDescription"))  }}
 			developerFields = mesg.DeveloperFields
@@ -133,7 +133,7 @@ func (m *{{ .Name }}) ToMesg(options *Options) proto.Message {
 
 	mesg.Fields = make([]proto.Field, len(fields))
 	copy(mesg.Fields, fields)
-	clear(fields) {{/* In case of unknown field or field.Value contains pointer to a slice */}}
+	*arr = [poolsize]proto.Field{} {{/* In case of unknown field or field.Value contains pointer to a slice */}}
 	pool.Put(arr)
 
 	{{ if and (not (eq .Name "FileId")) (not (eq .Name "DeveloperDataId")) (not (eq .Name "FieldDescription"))  }}

diff --git a/profile/mesgdef/aad_accel_features_gen.go b/profile/mesgdef/aad_accel_features_gen.go
diff --git a/profile/mesgdef/accelerometer_data_gen.go b/profile/mesgdef/accelerometer_data_gen.go
diff --git a/profile/mesgdef/activity_gen.go b/profile/mesgdef/activity_gen.go
diff --git a/profile/mesgdef/ant_channel_id_gen.go b/profile/mesgdef/ant_channel_id_gen.go
diff --git a/profile/mesgdef/ant_rx_gen.go b/profile/mesgdef/ant_rx_gen.go
diff --git a/profile/mesgdef/ant_tx_gen.go b/profile/mesgdef/ant_tx_gen.go
diff --git a/profile/mesgdef/aviation_attitude_gen.go b/profile/mesgdef/aviation_attitude_gen.go
diff --git a/profile/mesgdef/barometer_data_gen.go b/profile/mesgdef/barometer_data_gen.go
diff --git a/profile/mesgdef/beat_intervals_gen.go b/profile/mesgdef/beat_intervals_gen.go
diff --git a/profile/mesgdef/bike_profile_gen.go b/profile/mesgdef/bike_profile_gen.go
diff --git a/profile/mesgdef/blood_pressure_gen.go b/profile/mesgdef/blood_pressure_gen.go
diff --git a/profile/mesgdef/cadence_zone_gen.go b/profile/mesgdef/cadence_zone_gen.go
diff --git a/profile/mesgdef/camera_event_gen.go b/profile/mesgdef/camera_event_gen.go
diff --git a/profile/mesgdef/capabilities_gen.go b/profile/mesgdef/capabilities_gen.go
diff --git a/profile/mesgdef/chrono_shot_data_gen.go b/profile/mesgdef/chrono_shot_data_gen.go
diff --git a/profile/mesgdef/chrono_shot_session_gen.go b/profile/mesgdef/chrono_shot_session_gen.go
diff --git a/profile/mesgdef/climb_pro_gen.go b/profile/mesgdef/climb_pro_gen.go
diff --git a/profile/mesgdef/connectivity_gen.go b/profile/mesgdef/connectivity_gen.go
diff --git a/profile/mesgdef/course_gen.go b/profile/mesgdef/course_gen.go
diff --git a/profile/mesgdef/course_point_gen.go b/profile/mesgdef/course_point_gen.go
diff --git a/profile/mesgdef/developer_data_id_gen.go b/profile/mesgdef/developer_data_id_gen.go